GHSA-ff66-236v-p4fg

Summary

A vulnerability allows crafted block attribute values to bypass server-side attribute escaping when an HTML entity is mixed with raw special characters. An attacker can embed a malicious IAL value inside a .sy document, package it as a .sy.zip, and have the victim import it through the normal Import -> SiYuan .sy.zip workflow. Once the note is opened, the malicious attribute breaks out of its original HTML context and injects an event handler, resulting in stored XSS. In the Electron desktop client, this XSS reaches remote code execution because injected JavaScript runs with access to Node/Electron APIs.

Details

The issue is caused by a logic regression in escapeNodeAttributeValues in kernel/filesys/tree.go. Previously, the escaping logic converted node.KramdownIAL with parse.IAL2Map(...) before deciding whether a value needed escaping. That conversion unescaped existing entities first, so mixed values such as:

&" onmouseenter="alert('IAL-XSS')

were still recognized as unsafe and escaped correctly. The logic changed to inspect raw KramdownIAL values directly. The new needsEscapeForValue implementation returns false as soon as it sees any known entity such as &, ", <, or >. This means a value containing both an entity and an unescaped raw quote bypasses escaping entirely.

That bypass becomes exploitable because the renderer later inserts block IAL values directly into HTML attributes. A payload like:

&" onmouseenter="require('child_process').exec('calc')

can be rendered into HTML equivalent to:

<div title="&amp;" onmouseenter="require('child_process').exec('calc')">

This creates a stored XSS condition. In SiYuan Desktop, the Electron renderer runs with Node.js integration available, so attacker-controlled JavaScript can invoke Node APIs directly. As a result, the issue is not limited to script execution in the page context and becomes arbitrary command execution on the victim’s machine.

The stored XSS path was validated by importing a crafted .sy.zip through the normal GUI and triggering JavaScript execution from the rendered block. Because the same injected JavaScript runs in the privileged Electron renderer, this is an RCE issue in the desktop client.

PoC

1. Start SiYuan Desktop v3.6.1.
2. Prepare a crafted .sy.zip containing a .sy document with a block IAL property such as:

"title": "&\" onmouseenter=\"require('child_process').exec('calc')"

1. In the UI, right-click any notebook.
2. Select Import -> SiYuan .sy.zip.
3. Import the crafted archive.
4. Open the imported note.
5. Move the mouse over the affected paragraph block.
6. Observe that the injected JavaScript executes.
7. On Windows, calc.exe launches, demonstrating arbitrary command execution.

Impact

This vulnerability allows an attacker to deliver a malicious .sy.zip file that executes attacker-controlled JavaScript after import. In the desktop application, that JavaScript runs with Node/Electron privileges and can execute arbitrary operating system commands under the victim’s account. This makes the bug equivalent to local code execution triggered by importing and opening attacker-supplied content.