Open-Source Security Intelligence

Know every vulnerability
before it knows you.

DevGuard continuously monitors your dependencies and alerts you when CVEs like this one affect your stack — with real-time threat intelligence built for developers.

Checkout DevGuardView on GitHub
Search

GHSA-5v93-9mqw-p9mh

HighCVSS 8.8 / 10
Published Feb 14, 2025·Last modified Feb 14, 2025
Affected Components(0)

No affected components available

Description

Summary

A vulnerability in the add_share function of the Rewards pallet (part of the ORML repository) can lead to an uncaught Rust panic when handling user-provided input exceeding the u128 range.

Affected Components

  • ORML Rewards pallet (rewards/src/lib.rs)
  • Any Substrate-based chain using ORML Rewards with add_share accepting unvalidated large u128 inputs

Technical Details

  • add_share performs arithmetic on user-supplied values (add_amount) of type T::Share (mapped to u128 in Acala).
  • If add_amount is large enough (e.g., i128::MAX), the intermediate result may overflow and panic on the cast to u128.
  • Validation occurs only after arithmetic, enabling a crafted input to trigger an overflow.

Impact

A malicious user submitting a specially crafted extrinsic can cause a panic in the runtime:

  • Denial of Service by crashing the node process.
  • Potential for invalid blocks produced by validators.

Likelihood

This issue is exploitable in production if there exists at least one rewards pool where reward tokens exceed twice the collateral tokens, allowing sufficiently large multiplication to exceed u128 bounds.

Remediation

  • This issue is fixed in https://github.com/open-web3-stack/open-runtime-module-library/pull/1016

Backport

The patch have been backported to following release branches:

  • polkadot-stable2407
  • polkadot-stable2409

A 1.0.1 patch release is made with this fix.

Risk Scores
Base Score
8.8

The vulnerability can be exploited over the network without needing physical access. It is easy for an attacker to exploit this vulnerability. An attacker does not need any special privileges or access rights. No user interaction is needed for the attacker to exploit this vulnerability.

Threat Intelligence
6.7

Exploitation attempts have been detected. Elevated vigilance and prompt remediation are advised.

EPSS
N/A

Probability that this vulnerability will be exploited in the wild within the next 30 days.

Exploit
Not available

We did not find any exploit available. Neither in GitHub repositories nor in the Exploit-Database.

Browse More

High severity
Scan your project

Continuously monitor your dependencies and get alerted when vulnerabilities like this one affect your stack.

Checkout DevGuard